checkpatch: Add explicit test for mailing list as author.

Somehow some such patches snuck through.  checkpatch caught them (and the
committer missed that) but this makes it even more explicit.

Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>

diff --git a/tests/checkpatch.at b/tests/checkpatch.at
index 8af3a8c0371ea27095027e26db989106e20073ee..bd7422494e3348c11beaee654bd2ab1d03e32ec8 100755 (executable)
--- a/tests/checkpatch.at
+++ b/tests/checkpatch.at
@@ -51,6 +51,14 @@ try_checkpatch \
     Commit: A" \
    "ERROR: Author A needs to sign off."
 
+# Single author but somehow the mailing list is the author.
+try_checkpatch \
+   "Author: Foo Bar via dev <ovs-dev@openvswitch.org>
+    Commit: A
+
+    Signed-off-by: A" \
+   "ERROR: Author should not be mailing list."
+
 # Sign-off for single author and different committer.
 try_checkpatch \
    "Author: A

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 5f5dd8318e328eef2ea9e726187c13dc9673da1c..54aa4b6346dbcf8353358d8b1ffb395dd65399b3 100755 (executable)
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -731,6 +731,9 @@ def ovs_checkpatch_parse(text, filename, author=None, committer=None):
                     if not author:
                         print_error("Patch lacks author.")
                         continue
+                    if " via " in author or "@openvswitch.org" in author:
+                        print_error("Author should not be mailing list.")
+                        continue
                     if author in co_authors:
                         print_error("Author should not be also be co-author.")
                         continue