drm/bridge: lvds-codec: Use dev_err_probe for error handling

dev_err_probe function simplifies error handling. So use the same in probe
function wherever possible.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201020093655.3584-1-biju.das.jz@bp.renesas.com

diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
index f52ccffc1bd1dcb3ac3f82797d821dd82034f564..dcf579a4cf833b0e453bdc707d7a0ac553cbeb06 100644 (file)
--- a/drivers/gpu/drm/bridge/lvds-codec.c
+++ b/drivers/gpu/drm/bridge/lvds-codec.c
@@ -80,7 +80,6 @@ static int lvds_codec_probe(struct platform_device *pdev)
        struct device_node *panel_node;
        struct drm_panel *panel;
        struct lvds_codec *lvds_codec;
-       int ret;
 
        lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL);
        if (!lvds_codec)
@@ -90,13 +89,9 @@ static int lvds_codec_probe(struct platform_device *pdev)
        lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);
 
        lvds_codec->vcc = devm_regulator_get(lvds_codec->dev, "power");
-       if (IS_ERR(lvds_codec->vcc)) {
-               ret = PTR_ERR(lvds_codec->vcc);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(lvds_codec->dev,
-                               "Unable to get \"vcc\" supply: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(lvds_codec->vcc))
+               return dev_err_probe(dev, PTR_ERR(lvds_codec->vcc),
+                                    "Unable to get \"vcc\" supply\n");
 
        lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
                                                             GPIOD_OUT_HIGH);