]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: staging: atomisp: Removed else branch in function
authorLeonid Kushnir <leonf008@gmail.com>
Tue, 6 Oct 2020 08:17:21 +0000 (10:17 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 22 Mar 2021 16:40:38 +0000 (17:40 +0100)
This patch fixes the checkpatch.pl warning :

WARNING: else is not generally useful after a break or return

Expressions under 'else' branch in function 'gc0310_s_power' are
executed whenever the exppression in 'if' is False. Otherwise, return
from function occurs. Therefore, there is no need in 'else', and it has
been removed.

Link: https://lore.kernel.org/linux-media/20201006081721.GA35979@linux
Signed-off-by: Leonid Kushnir <leonf008@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

index 6be3ee1d93a543c8a983f8614391e2fbad30f393..8201c15b57699393aef9d8da744053e0dd3e0c67 100644 (file)
@@ -874,11 +874,10 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on)
 
        if (on == 0)
                return power_down(sd);
-       else {
-               ret = power_up(sd);
-               if (!ret)
-                       return gc0310_init(sd);
-       }
+       ret = power_up(sd);
+       if (!ret)
+               return gc0310_init(sd);
+
        return ret;
 }