KVM: x86: Protect kvm_lapic_reg_write() from Spectre-v1/L1TF attacks

BugLink: https://bugs.launchpad.net/bugs/1866678
commit 4bf79cb089f6b1c6c632492c0271054ce52ad766 upstream.

This fixes a Spectre-v1/L1TF vulnerability in kvm_lapic_reg_write().
This function contains index computations based on the
(attacker-controlled) MSR number.

Fixes: 0105d1a52640 ("KVM: x2apic interface to lapic")
Signed-off-by: Nick Finco <nifi@google.com>
Signed-off-by: Marios Pomonis <pomonis@google.com>
Reviewed-by: Andrew Honig <ahonig@google.com>
Cc: stable@vger.kernel.org
Reviewed-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 2932bea9d97c871073c0075dcc6aca86af8ade39..53bbd9fae36fa64b09f5a297c9b9645b7508e711 100644 (file)
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -1795,15 +1795,20 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val)
        case APIC_LVTTHMR:
        case APIC_LVTPC:
        case APIC_LVT1:
-       case APIC_LVTERR:
+       case APIC_LVTERR: {
                /* TODO: Check vector */
+               size_t size;
+               u32 index;
+
                if (!kvm_apic_sw_enabled(apic))
                        val |= APIC_LVT_MASKED;
-
-               val &= apic_lvt_mask[(reg - APIC_LVTT) >> 4];
+               size = ARRAY_SIZE(apic_lvt_mask);
+               index = array_index_nospec(
+                               (reg - APIC_LVTT) >> 4, size);
+               val &= apic_lvt_mask[index];
                kvm_lapic_set_reg(apic, reg, val);
-
                break;
+       }
 
        case APIC_LVTT:
                if (!kvm_apic_sw_enabled(apic))