]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
tcp: add tracing of skb/skaddr in tcp_event_sk_skb class
authorJason Xing <kernelxing@tencent.com>
Mon, 4 Mar 2024 09:29:33 +0000 (17:29 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 7 Mar 2024 14:29:15 +0000 (15:29 +0100)
Printing the addresses can help us identify the exact skb/sk
for those system in which it's not that easy to run BPF program.
As we can see, it already fetches those, then use it directly
and it will print like below:

...tcp_retransmit_skb: skbaddr=XXX skaddr=XXX family=AF_INET...

Signed-off-by: Jason Xing <kernelxing@tencent.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
include/trace/events/tcp.h

index 7b1ddffa3dfc825f431bc575f4e86a3509dc9426..ac36067ae066f319eb092bbb112256099ef8169d 100644 (file)
@@ -88,7 +88,8 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
                              sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
        ),
 
-       TP_printk("family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
+       TP_printk("skbaddr=%p skaddr=%p family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
+                 __entry->skbaddr, __entry->skaddr,
                  show_family_name(__entry->family),
                  __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
                  __entry->saddr_v6, __entry->daddr_v6,