]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ASoC: stm32: dfsdm: manage cb buffers cleanup
authorOlivier Moysan <olivier.moysan@foss.st.com>
Wed, 9 Nov 2022 17:08:49 +0000 (18:08 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 13:00:30 +0000 (14:00 +0100)
[ Upstream commit 7d945b046be3d2605dbb1806e73095aadd7ae129 ]

Ensure that resources allocated by iio_channel_get_all_cb()
are released on driver unbind.

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
Link: https://lore.kernel.org/r/20221109170849.273719-1-olivier.moysan@foss.st.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 4c13ddb74f2c8fcda8bb971dabac7f07b71b7653)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
sound/soc/stm/stm32_adfsdm.c

index e6078f50e508e05210c223f0e2d1cfcfe4227e8d..1e9b4b1df69e3eaea2b1786f3688cc20c00c6d02 100644 (file)
@@ -303,6 +303,11 @@ static int stm32_adfsdm_dummy_cb(const void *data, void *private)
        return 0;
 }
 
+static void stm32_adfsdm_cleanup(void *data)
+{
+       iio_channel_release_all_cb(data);
+}
+
 static struct snd_soc_component_driver stm32_adfsdm_soc_platform = {
        .open           = stm32_adfsdm_pcm_open,
        .close          = stm32_adfsdm_pcm_close,
@@ -349,6 +354,12 @@ static int stm32_adfsdm_probe(struct platform_device *pdev)
        if (IS_ERR(priv->iio_cb))
                return PTR_ERR(priv->iio_cb);
 
+       ret = devm_add_action_or_reset(&pdev->dev, stm32_adfsdm_cleanup, priv->iio_cb);
+       if (ret < 0)  {
+               dev_err(&pdev->dev, "Unable to add action\n");
+               return ret;
+       }
+
        component = devm_kzalloc(&pdev->dev, sizeof(*component), GFP_KERNEL);
        if (!component)
                return -ENOMEM;