]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
staging: r8188eu: use GFP_ATOMIC under spinlock
authorMichael Straube <straube.linux@gmail.com>
Thu, 19 Aug 2021 15:29:14 +0000 (17:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Aug 2021 08:40:27 +0000 (10:40 +0200)
kmalloc() in function update_bcn_wps_ie() is called under a spinlock
so the allocation have to be atomic.

-> update_beacon() <- takes a spinlock
   -> update_bcn_vendor_spec_ie()
      -> update_bcn_wps_ie()

Fixes: 79f712ea994de ("staging: r8188eu: Remove wrappers for kalloc() and kzalloc()")
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210819152914.17482-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_ap.c

index 1127e9a524584ba35687189d6a4a5e49b643b322..9c81cd318e62f37436e0f506d26c9f9cc278e460 100644 (file)
@@ -1293,7 +1293,7 @@ static void update_bcn_wps_ie(struct adapter *padapter)
        remainder_ielen = ielen - wps_offset - wps_ielen;
 
        if (remainder_ielen > 0) {
-               pbackup_remainder_ie = kmalloc(remainder_ielen, GFP_KERNEL);
+               pbackup_remainder_ie = kmalloc(remainder_ielen, GFP_ATOMIC);
                if (pbackup_remainder_ie)
                        memcpy(pbackup_remainder_ie, premainder_ie, remainder_ielen);
        }