]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: cec: don't select PCI & DMI
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 17 Apr 2020 06:49:06 +0000 (08:49 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 17 Apr 2020 06:49:06 +0000 (08:49 +0200)
While select would be a great idea for most archs, this
causes a breakage with s390:

"I don't think that's a good idea, as it suddenly enables selecting all PCI
 drivers on platforms that do not have PCI.

    WARNING: unmet direct dependencies detected for PCI
      Depends on [n]: HAVE_PCI [=n]
      Selected by [m]:
      - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/cec/platform/Kconfig

index 2c4dd7401dd8be34050295004ca5930afa96b6e9..350533cd8261244c10e800b4bffe47954f87d261 100644 (file)
@@ -100,8 +100,7 @@ config CEC_TEGRA
 config CEC_SECO
        tristate "SECO Boards HDMI CEC driver"
        depends on (X86 || IA64) || COMPILE_TEST
-       select PCI
-       select DMI
+       depends on PCI && DMI
        select CEC_CORE
        select CEC_NOTIFIER
        help