]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 2 Apr 2021 09:32:55 +0000 (11:32 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 6 Apr 2021 14:10:05 +0000 (16:10 +0200)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/qcom/camss/camss-csid.c

index 463760c292943710ed33c32110c0cae08246265b..cc11fbfdae132a9d7a8066f9453233bd218724f5 100644 (file)
@@ -568,10 +568,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
 
        r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
        csid->base = devm_ioremap_resource(dev, r);
-       if (IS_ERR(csid->base)) {
-               dev_err(dev, "could not map memory\n");
+       if (IS_ERR(csid->base))
                return PTR_ERR(csid->base);
-       }
 
        /* Interrupt */