]> git.proxmox.com Git - mirror_zfs.git/commitdiff
Cleanup: zvol_add_clones() should not NULL check dp
authorRichard Yao <richard.yao@alumni.stonybrook.edu>
Mon, 17 Oct 2022 06:18:09 +0000 (02:18 -0400)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Tue, 18 Oct 2022 22:39:48 +0000 (15:39 -0700)
It is never NULL because we return early if dsl_pool_hold() fails.

This caused Coverity to complain.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14042

module/zfs/zvol.c

index 2e2860ff02124fdff30bfe89adfa76b823f094e8..be8ee34f27ae4496db081c7c71c4ceb4eb5f4ca9 100644 (file)
@@ -1026,8 +1026,7 @@ zvol_add_clones(const char *dsname, list_t *minors_list)
 out:
        if (dd != NULL)
                dsl_dir_rele(dd, FTAG);
-       if (dp != NULL)
-               dsl_pool_rele(dp, FTAG);
+       dsl_pool_rele(dp, FTAG);
 }
 
 /*