]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds
authorLiviu Dudau <liviu@dudau.co.uk>
Thu, 18 Oct 2018 00:14:32 +0000 (01:14 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Fri, 26 Oct 2018 18:51:36 +0000 (20:51 +0200)
Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
removed the common code path that set the led_dat->gpiod pointer in
create_gpio_led(), but only added it back for the devices that have
a valid gpio_led_platform_data structure. Calling gpio_leds_create()
in gpio_led_probe() is not enough to get a valid gpiod pointer.

Fortunately enough, gpio_leds_create() already gets the needed pointer,
we just need to assign it to the relevant gpio_led_data structure.

Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/leds-gpio.c

index 32fa752565bc90421d55e5b8dd98eec0e208ff14..45e012093865896204fa37bfc9221ea9260af50d 100644 (file)
@@ -163,6 +163,8 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
                        return ERR_CAST(led.gpiod);
                }
 
+               led_dat->gpiod = led.gpiod;
+
                fwnode_property_read_string(child, "linux,default-trigger",
                                            &led.default_trigger);