]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
uacce: add print information if not enable sva
authorKai Ye <yekai13@huawei.com>
Wed, 9 Jun 2021 10:09:05 +0000 (18:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jun 2021 16:53:29 +0000 (18:53 +0200)
Add print information necessary if user not enable sva.

Signed-off-by: Kai Ye <yekai13@huawei.com>
Link: https://lore.kernel.org/r/1623233345-8765-1-git-send-email-yekai13@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/uacce/uacce.c

index bae18ef03dcb4732420932708d8f5ad31bb85515..488eeb2811aeb3d0a0df6d300c563bdfa439c535 100644 (file)
@@ -387,15 +387,22 @@ static void uacce_release(struct device *dev)
 
 static unsigned int uacce_enable_sva(struct device *parent, unsigned int flags)
 {
+       int ret;
+
        if (!(flags & UACCE_DEV_SVA))
                return flags;
 
        flags &= ~UACCE_DEV_SVA;
 
-       if (iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_IOPF))
+       ret = iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_IOPF);
+       if (ret) {
+               dev_err(parent, "failed to enable IOPF feature! ret = %pe\n", ERR_PTR(ret));
                return flags;
+       }
 
-       if (iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_SVA)) {
+       ret = iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_SVA);
+       if (ret) {
+               dev_err(parent, "failed to enable SVA feature! ret = %pe\n", ERR_PTR(ret));
                iommu_dev_disable_feature(parent, IOMMU_DEV_FEAT_IOPF);
                return flags;
        }