the retry logic was broken because the complete status
of the task structure was not reset. this resulted in
an infinite loop retrying the command over and over.
CC: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
if (iTask->retries-- > 0 && status == SCSI_STATUS_CHECK_CONDITION
&& task->sense.key == SCSI_SENSE_UNIT_ATTENTION) {
+ error_report("iSCSI CheckCondition: %s", iscsi_get_error(iscsi));
iTask->do_retry = 1;
goto out;
}
if (status != SCSI_STATUS_GOOD) {
- error_report("iSCSI: Failure. %s", iscsi_get_error(iscsi));
+ error_report("iSCSI Failure: %s", iscsi_get_error(iscsi));
}
out:
}
if (iTask.do_retry) {
+ iTask.complete = 0;
goto retry;
}
}
if (iTask.do_retry) {
+ iTask.complete = 0;
goto retry;
}
}
if (iTask.do_retry) {
+ iTask.complete = 0;
goto retry;
}
scsi_free_scsi_task(iTask.task);
iTask.task = NULL;
}
+ iTask.complete = 0;
goto retry;
}
}
if (iTask.do_retry) {
+ iTask.complete = 0;
goto retry;
}
}
if (iTask.do_retry) {
+ iTask.complete = 0;
goto retry;
}