]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
net/mlx5: Continue driver initialization despite debugfs failure
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 13 Dec 2018 11:15:11 +0000 (13:15 +0200)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:21:29 +0000 (14:21 -0300)
BugLink: https://bugs.launchpad.net/bugs/1855787
[ Upstream commit 199fa087dc6b503baad06712716fac645a983e8a ]

The failure to create debugfs entry is unpleasant event, but not enough
to abort drier initialization. Align the mlx5_core code to debugfs design
and continue execution whenever debugfs_create_dir() successes or not.

Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/net/ethernet/mellanox/mlx5/core/main.c

index 6bd16e382d5c93718ae7a28e201387e6e2081333..e40a0416b0b14bbed184204c16cdf2c15cfcdbaa 100644 (file)
@@ -842,11 +842,9 @@ static int mlx5_pci_init(struct mlx5_core_dev *dev, struct mlx5_priv *priv)
 
        priv->numa_node = dev_to_node(&dev->pdev->dev);
 
-       priv->dbg_root = debugfs_create_dir(dev_name(&pdev->dev), mlx5_debugfs_root);
-       if (!priv->dbg_root) {
-               dev_err(&pdev->dev, "Cannot create debugfs dir, aborting\n");
-               return -ENOMEM;
-       }
+       if (mlx5_debugfs_root)
+               priv->dbg_root =
+                       debugfs_create_dir(pci_name(pdev), mlx5_debugfs_root);
 
        err = mlx5_pci_enable_device(dev);
        if (err) {