]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
usb: isp1760: use the right irq status bit
authorRui Miguel Silva <rui.silva@linaro.org>
Fri, 27 Aug 2021 13:11:53 +0000 (14:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Aug 2021 14:11:39 +0000 (16:11 +0200)
Instead of using the fields enum values to check interrupts
trigged, use the correct bit values.

Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Link: https://lore.kernel.org/r/20210827131154.4151862-5-rui.silva@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/isp1760/isp1760-udc.c

index a78da59d6417b829be2fe7b19bb5dee87985621a..5cafd23345cad0eba99e6ec9482e925c65b66b16 100644 (file)
@@ -1363,7 +1363,7 @@ static irqreturn_t isp1760_udc_irq(int irq, void *dev)
 
        status = isp1760_udc_irq_get_status(udc);
 
-       if (status & DC_IEVBUS) {
+       if (status & ISP176x_DC_IEVBUS) {
                dev_dbg(udc->isp->dev, "%s(VBUS)\n", __func__);
                /* The VBUS interrupt is only triggered when VBUS appears. */
                spin_lock(&udc->lock);
@@ -1371,7 +1371,7 @@ static irqreturn_t isp1760_udc_irq(int irq, void *dev)
                spin_unlock(&udc->lock);
        }
 
-       if (status & DC_IEBRST) {
+       if (status & ISP176x_DC_IEBRST) {
                dev_dbg(udc->isp->dev, "%s(BRST)\n", __func__);
 
                isp1760_udc_reset(udc);
@@ -1391,18 +1391,18 @@ static irqreturn_t isp1760_udc_irq(int irq, void *dev)
                }
        }
 
-       if (status & DC_IEP0SETUP) {
+       if (status & ISP176x_DC_IEP0SETUP) {
                dev_dbg(udc->isp->dev, "%s(EP0SETUP)\n", __func__);
 
                isp1760_ep0_setup(udc);
        }
 
-       if (status & DC_IERESM) {
+       if (status & ISP176x_DC_IERESM) {
                dev_dbg(udc->isp->dev, "%s(RESM)\n", __func__);
                isp1760_udc_resume(udc);
        }
 
-       if (status & DC_IESUSP) {
+       if (status & ISP176x_DC_IESUSP) {
                dev_dbg(udc->isp->dev, "%s(SUSP)\n", __func__);
 
                spin_lock(&udc->lock);
@@ -1413,7 +1413,7 @@ static irqreturn_t isp1760_udc_irq(int irq, void *dev)
                spin_unlock(&udc->lock);
        }
 
-       if (status & DC_IEHS_STA) {
+       if (status & ISP176x_DC_IEHS_STA) {
                dev_dbg(udc->isp->dev, "%s(HS_STA)\n", __func__);
                udc->gadget.speed = USB_SPEED_HIGH;
        }