]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
pwm: imx27: Simplify using devm_pwmchip_add()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:28:04 +0000 (18:28 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 2 Sep 2021 19:38:42 +0000 (21:38 +0200)
This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-imx27.c

index f6588a96fbd98b9952c7c2a4c102c415649c4d5f..ea91a2f81a9fcc7bf357e1860bbeaaafc51853ff 100644 (file)
@@ -313,8 +313,6 @@ static int pwm_imx27_probe(struct platform_device *pdev)
        if (imx == NULL)
                return -ENOMEM;
 
-       platform_set_drvdata(pdev, imx);
-
        imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
        if (IS_ERR(imx->clk_ipg))
                return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_ipg),
@@ -342,16 +340,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
        if (!(pwmcr & MX3_PWMCR_EN))
                pwm_imx27_clk_disable_unprepare(imx);
 
-       return pwmchip_add(&imx->chip);
-}
-
-static int pwm_imx27_remove(struct platform_device *pdev)
-{
-       struct pwm_imx27_chip *imx;
-
-       imx = platform_get_drvdata(pdev);
-
-       return pwmchip_remove(&imx->chip);
+       return devm_pwmchip_add(&pdev->dev, &imx->chip);
 }
 
 static struct platform_driver imx_pwm_driver = {
@@ -360,7 +349,6 @@ static struct platform_driver imx_pwm_driver = {
                .of_match_table = pwm_imx27_dt_ids,
        },
        .probe = pwm_imx27_probe,
-       .remove = pwm_imx27_remove,
 };
 module_platform_driver(imx_pwm_driver);