]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
arm64: dts: qcom: msm8916: Disable coresight by default
authorMichael Srba <michael.srba@seznam.cz>
Wed, 13 May 2020 18:47:35 +0000 (20:47 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 13 May 2020 21:21:14 +0000 (14:21 -0700)
On some msm8916 devices, attempts at initializing coresight cause the boot to
fail. This was fixed by disabling the coresight-related nodes in the board dts
files. However, a cleaner approach was chosen for fixing the same issue on
msm8998: disabling coresight by default, and enabling it in board dts files
where desired.

This patch implements the same solution for msm8916, removes now redundant
overwrites in board specific dts files and and enables coresight in db410c's
board dts in order to keep the current behavior.

Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
Signed-off-by: Michael Srba <michael.srba@seznam.cz>
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Link: https://lore.kernel.org/r/20200513184735.30104-1-michael.srba@seznam.cz
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
arch/arm64/boot/dts/qcom/msm8916.dtsi

index 14982762088d97643d4914bc103f9340b88474e3..7377bf73390ab03598e4fbeae0ae8d87fa91083f 100644 (file)
                wcnss@a21b000 {
                        status = "okay";
                };
+
+               tpiu@820000 { status = "okay"; };
+               funnel@821000 { status = "okay"; };
+               replicator@824000 { status = "okay"; };
+               etf@825000 { status = "okay"; };
+               etr@826000 { status = "okay"; };
+               funnel@841000 { status = "okay"; };
+               debug@850000 { status = "okay"; };
+               debug@852000 { status = "okay"; };
+               debug@854000 { status = "okay"; };
+               debug@856000 { status = "okay"; };
+               etm@85c000 { status = "okay"; };
+               etm@85d000 { status = "okay"; };
+               etm@85e000 { status = "okay"; };
+               etm@85f000 { status = "okay"; };
+               cti@810000 { status = "okay"; };
+               cti@811000 { status = "okay"; };
+               cti@858000 { status = "okay"; };
+               cti@859000 { status = "okay"; };
+               cti@85a000 { status = "okay"; };
+               cti@85b000 { status = "okay"; };
        };
 
        usb2513 {
index d1ccb9472c8bdb027ae9b37c938b405aa0b185d7..691eb1a87bc9463dfafd54d39c7be6b23c67d007 100644 (file)
                wcnss@a21b000 {
                        status = "okay";
                };
-
-               /*
-                * Attempting to enable these devices causes a "synchronous
-                * external abort". Suspected cause is that the debug power
-                * domain is not enabled by default on this device.
-                * Disable these devices for now to avoid the crash.
-                *
-                * See: https://lore.kernel.org/linux-arm-msm/20190618202623.GA53651@gerhold.net/
-                */
-               tpiu@820000 { status = "disabled"; };
-               funnel@821000 { status = "disabled"; };
-               replicator@824000 { status = "disabled"; };
-               etf@825000 { status = "disabled"; };
-               etr@826000 { status = "disabled"; };
-               funnel@841000 { status = "disabled"; };
-               debug@850000 { status = "disabled"; };
-               debug@852000 { status = "disabled"; };
-               debug@854000 { status = "disabled"; };
-               debug@856000 { status = "disabled"; };
-               etm@85c000 { status = "disabled"; };
-               etm@85d000 { status = "disabled"; };
-               etm@85e000 { status = "disabled"; };
-               etm@85f000 { status = "disabled"; };
        };
 
        // FIXME: Use extcon device provided by charger driver when available
index 019407f93149adbd7c071218912d611f83c5013f..8b5060f4fe0ba98cdcb40a6edf6808c529c879ca 100644 (file)
                wcnss@a21b000 {
                        status = "okay";
                };
-
-               /*
-                * Attempting to enable these devices causes a "synchronous
-                * external abort". Suspected cause is that the debug power
-                * domain is not enabled by default on this device.
-                * Disable these devices for now to avoid the crash.
-                *
-                * See: https://lore.kernel.org/linux-arm-msm/20190618202623.GA53651@gerhold.net/
-                */
-               tpiu@820000 { status = "disabled"; };
-               funnel@821000 { status = "disabled"; };
-               replicator@824000 { status = "disabled"; };
-               etf@825000 { status = "disabled"; };
-               etr@826000 { status = "disabled"; };
-               funnel@841000 { status = "disabled"; };
-               debug@850000 { status = "disabled"; };
-               debug@852000 { status = "disabled"; };
-               debug@854000 { status = "disabled"; };
-               debug@856000 { status = "disabled"; };
-               etm@85c000 { status = "disabled"; };
-               etm@85d000 { status = "disabled"; };
-               etm@85e000 { status = "disabled"; };
-               etm@85f000 { status = "disabled"; };
        };
 
        gpio-keys {
index 57ab5573a2d25ba5fe1d2e60fd08f02b085fee5a..cf9ce4a9c912bb67245c5137bec962599af9a103 100644 (file)
                        clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
                        clock-names = "apb_pclk", "atclk";
 
+                       status = "disabled";
+
                        in-ports {
                                port {
                                        tpiu_in: endpoint {
                        clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
                        clock-names = "apb_pclk", "atclk";
 
+                       status = "disabled";
+
                        in-ports {
                                #address-cells = <1>;
                                #size-cells = <0>;
                        clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
                        clock-names = "apb_pclk", "atclk";
 
+                       status = "disabled";
+
                        out-ports {
                                #address-cells = <1>;
                                #size-cells = <0>;
                        clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
                        clock-names = "apb_pclk", "atclk";
 
+                       status = "disabled";
+
                        in-ports {
                                port {
                                        etf_in: endpoint {
                        clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
                        clock-names = "apb_pclk", "atclk";
 
+                       status = "disabled";
+
                        in-ports {
                                port {
                                        etr_in: endpoint {
                        clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
                        clock-names = "apb_pclk", "atclk";
 
+                       status = "disabled";
+
                        in-ports {
                                #address-cells = <1>;
                                #size-cells = <0>;
                        clocks = <&rpmcc RPM_QDSS_CLK>;
                        clock-names = "apb_pclk";
                        cpu = <&CPU0>;
+                       status = "disabled";
                };
 
                debug@852000 {
                        clocks = <&rpmcc RPM_QDSS_CLK>;
                        clock-names = "apb_pclk";
                        cpu = <&CPU1>;
+                       status = "disabled";
                };
 
                debug@854000 {
                        clocks = <&rpmcc RPM_QDSS_CLK>;
                        clock-names = "apb_pclk";
                        cpu = <&CPU2>;
+                       status = "disabled";
                };
 
                debug@856000 {
                        clocks = <&rpmcc RPM_QDSS_CLK>;
                        clock-names = "apb_pclk";
                        cpu = <&CPU3>;
+                       status = "disabled";
                };
 
                etm0: etm@85c000 {
 
                        cpu = <&CPU0>;
 
+                       status = "disabled";
+
                        out-ports {
                                port {
                                        etm0_out: endpoint {
 
                        cpu = <&CPU1>;
 
+                       status = "disabled";
+
                        out-ports {
                                port {
                                        etm1_out: endpoint {
 
                        cpu = <&CPU2>;
 
+                       status = "disabled";
+
                        out-ports {
                                port {
                                        etm2_out: endpoint {
 
                        cpu = <&CPU3>;
 
+                       status = "disabled";
+
                        out-ports {
                                port {
                                        etm3_out: endpoint {
 
                        clocks = <&rpmcc RPM_QDSS_CLK>;
                        clock-names = "apb_pclk";
+
+                       status = "disabled";
                };
 
                /* CTI 1 - TPIU connections */
 
                        clocks = <&rpmcc RPM_QDSS_CLK>;
                        clock-names = "apb_pclk";
+
+                       status = "disabled";
                };
 
                /* CTIs 2-11 - no information - not instantiated */
                        cpu = <&CPU0>;
                        arm,cs-dev-assoc = <&etm0>;
 
+                       status = "disabled";
                };
 
                /* CTI - CPU-1 */
 
                        cpu = <&CPU1>;
                        arm,cs-dev-assoc = <&etm1>;
+
+                       status = "disabled";
                };
 
                /* CTI - CPU-2 */
 
                        cpu = <&CPU2>;
                        arm,cs-dev-assoc = <&etm2>;
+
+                       status = "disabled";
                };
 
                /* CTI - CPU-3 */
 
                        cpu = <&CPU3>;
                        arm,cs-dev-assoc = <&etm3>;
+
+                       status = "disabled";
                };