]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
platform/chrome: cros_ec_typec: Add a dependency on USB_ROLE_SWITCH
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Mon, 29 Jun 2020 10:32:23 +0000 (12:32 +0200)
committerEnric Balletbo i Serra <enric.balletbo@collabora.com>
Tue, 30 Jun 2020 13:46:39 +0000 (15:46 +0200)
As reported by the kernel test robot the cros_ec_typec driver fails to
build if the USB_ROLE_SWITCH is not selected, to fix that, add a
dependency on that symbol. This fixes the following build error:

   drivers/platform/chrome/cros_ec_typec.c:133: undefined reference to `usb_role_switch_put'
   ld: drivers/platform/chrome/cros_ec_typec.o: in function `cros_typec_get_switch_handles':
   drivers/platform/chrome/cros_ec_typec.c:108: undefined reference to `fwnode_usb_role_switch_get'
   ld: drivers/platform/chrome/cros_ec_typec.c:117: undefined reference to `usb_role_switch_put'

Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Prashant Malani <pmalani@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
drivers/platform/chrome/Kconfig

index cf072153bdc5de2d464027c9bb578773dd686e9a..a056031dee8114811a371fbc3e4ef48691711a24 100644 (file)
@@ -218,6 +218,7 @@ config CROS_EC_TYPEC
        tristate "ChromeOS EC Type-C Connector Control"
        depends on MFD_CROS_EC_DEV && TYPEC
        depends on CROS_USBPD_NOTIFY
+       depends on USB_ROLE_SWITCH
        default MFD_CROS_EC_DEV
        help
          If you say Y here, you get support for accessing Type C connector