RDMA/mad: Allocate zeroed MAD buffer

Ensure that MAD output buffer is zero-based allocated in all the callers
of process_mad and remove the various memset()'s from the drivers.

Link: https://lore.kernel.org/r/20191029062745.7932-3-leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 92c932c067cb186b3f9b1c6589b294c773208cae..62c756ea5668e3f2c5ad39a46f20ac320306f549 100644 (file)
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -481,8 +481,8 @@ static int get_perf_mad(struct ib_device *dev, int port_num, __be16 attr,
        if (!dev->ops.process_mad)
                return -ENOSYS;
 
-       in_mad  = kzalloc(sizeof *in_mad, GFP_KERNEL);
-       out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
+       in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL);
+       out_mad = kzalloc(sizeof(*out_mad), GFP_KERNEL);
        if (!in_mad || !out_mad) {
                ret = -ENOMEM;
                goto out;

diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index 57079110af9b5fb95fb1aaf4d13d8ae8aebc34e1..985cced5d5092278d21e052e8f46739d96018dd3 100644 (file)
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -966,7 +966,6 @@ static int iboe_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num,
        }
        mutex_unlock(&dev->counters_table[port_num - 1].mutex);
        if (stats_avail) {
-               memset(out_mad->data, 0, sizeof out_mad->data);
                switch (counter_stats.counter_mode & 0xf) {
                case 0:
                        edit_counter(&counter_stats,

diff --git a/drivers/infiniband/hw/mlx5/mad.c b/drivers/infiniband/hw/mlx5/mad.c
index 348c1df69cdc64ac729c93787a575a3c960372dd..0a5eb6e1798c60d5e7924c76a245d507ce1badb4 100644 (file)
--- a/drivers/infiniband/hw/mlx5/mad.c
+++ b/drivers/infiniband/hw/mlx5/mad.c
@@ -284,8 +284,6 @@ int mlx5_ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num,
                         *out_mad_size != sizeof(*out_mad)))
                return IB_MAD_RESULT_FAILURE;
 
-       memset(out_mad->data, 0, sizeof(out_mad->data));
-
        if (MLX5_CAP_GEN(dev->mdev, vport_counters) &&
            in_mad->mad_hdr.mgmt_class == IB_MGMT_CLASS_PERF_MGMT &&
            in_mad->mad_hdr.method == IB_MGMT_METHOD_GET) {

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index a902942adb5d3651a59fbbc033e62fb2b25c06e6..dda9b61f53b6763eb5257c8207e4ef16de1cf702 100644 (file)
--- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
@@ -675,7 +675,6 @@ int ocrdma_pma_counters(struct ocrdma_dev *dev,
 {
        struct ib_pma_portcounters *pma_cnt;
 
-       memset(out_mad->data, 0, sizeof out_mad->data);
        pma_cnt = (void *)(out_mad->data + 40);
        ocrdma_update_stats(dev);
 

diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index 818ec37a3215c79a10271efa76cd2fdb05d09ca6..6fbba0d5426987a2653bdb788ef023ca92f054c6 100644 (file)
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -2098,8 +2098,6 @@ static int cc_get_classportinfo(struct ib_cc_mad *ccp,
        struct ib_cc_classportinfo_attr *p =
                (struct ib_cc_classportinfo_attr *)ccp->mgmt_data;
 
-       memset(ccp->mgmt_data, 0, sizeof(ccp->mgmt_data));
-
        p->base_version = 1;
        p->class_version = 1;
        p->cap_mask = 0;
@@ -2120,8 +2118,6 @@ static int cc_get_congestion_info(struct ib_cc_mad *ccp,
        struct qib_ibport *ibp = to_iport(ibdev, port);
        struct qib_pportdata *ppd = ppd_from_ibp(ibp);
 
-       memset(ccp->mgmt_data, 0, sizeof(ccp->mgmt_data));
-
        p->congestion_info = 0;
        p->control_table_cap = ppd->cc_max_table_entries;
 
@@ -2138,8 +2134,6 @@ static int cc_get_congestion_setting(struct ib_cc_mad *ccp,
        struct qib_pportdata *ppd = ppd_from_ibp(ibp);
        struct ib_cc_congestion_entry_shadow *entries;
 
-       memset(ccp->mgmt_data, 0, sizeof(ccp->mgmt_data));
-
        spin_lock(&ppd->cc_shadow_lock);
 
        entries = ppd->congestion_entries_shadow->entries;
@@ -2176,8 +2170,6 @@ static int cc_get_congestion_control_table(struct ib_cc_mad *ccp,
        if (cct_block_index > IB_CC_TABLE_CAP_DEFAULT - 1)
                goto bail;
 
-       memset(ccp->mgmt_data, 0, sizeof(ccp->mgmt_data));
-
        spin_lock(&ppd->cc_shadow_lock);
 
        max_cct_block =