]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
fs/ntfs3: Keep prealloc for all types of files
authorKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Fri, 1 Oct 2021 15:48:49 +0000 (18:48 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Mon, 11 Oct 2021 16:10:19 +0000 (19:10 +0300)
Before we haven't kept prealloc for sparse files because we thought that
it will speed up create / write operations.
It lead to situation, when user reserved some space for sparse file,
filled volume, and wasn't able to write in reserved file.
With this commit we keep prealloc.
Now xfstest generic/274 pass.
Fixes: be71b5cba2e6 ("fs/ntfs3: Add attrib operations")
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/attrib.c

index 8a00fa978f5f9c3d496bd333bf1ace72d9194f37..e8c00dda42adbbff372908fdcb3d7d6814567cdf 100644 (file)
@@ -447,11 +447,8 @@ again:
 again_1:
        align = sbi->cluster_size;
 
-       if (is_ext) {
+       if (is_ext)
                align <<= attr_b->nres.c_unit;
-               if (is_attr_sparsed(attr_b))
-                       keep_prealloc = false;
-       }
 
        old_valid = le64_to_cpu(attr_b->nres.valid_size);
        old_size = le64_to_cpu(attr_b->nres.data_size);
@@ -461,9 +458,6 @@ again_1:
        new_alloc = (new_size + align - 1) & ~(u64)(align - 1);
        new_alen = new_alloc >> cluster_bits;
 
-       if (keep_prealloc && is_ext)
-               keep_prealloc = false;
-
        if (keep_prealloc && new_size < old_size) {
                attr_b->nres.data_size = cpu_to_le64(new_size);
                mi_b->dirty = true;