]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: imx-pxp: remove redundant dev_err call in pxp_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 1 Apr 2021 10:26:07 +0000 (12:26 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 6 Apr 2021 14:09:00 +0000 (16:09 +0200)
There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/imx-pxp.c

index 078d19afe35fff4c84d565db1d327bbc9d163a66..4321edc0c23d95fedc2b0d06614c2cb72bce18a3 100644 (file)
@@ -1654,11 +1654,8 @@ static int pxp_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        dev->mmio = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(dev->mmio)) {
-               ret = PTR_ERR(dev->mmio);
-               dev_err(&pdev->dev, "Failed to map register space: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(dev->mmio))
+               return PTR_ERR(dev->mmio);
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)