]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
Revert "drm/i915/ehl: Update MOCS table for EHL"
authorMatt Roper <matthew.d.roper@intel.com>
Tue, 12 Nov 2019 22:47:56 +0000 (14:47 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 13 Nov 2019 21:23:08 +0000 (13:23 -0800)
This reverts commit f4071997f1de016780ec6b79c63d90cd5886ee83.

These extra EHL entries won't behave as expected without a bit more work
on the kernel side so let's drop them until that kernel work has had a
chance to land.  Userspace trying to use these new entries won't get the
advantage of the new functionality these entries are meant to provide,
but at least it won't misbehave.

When we do add these back in the future, we'll probably want to
explicitly use separate tables for ICL and EHL so that userspace
software that mistakenly uses these entries (which are undefined on ICL)
sees the same behavior it sees with all the other undefined entries.

Cc: Francisco Jerez <francisco.jerez.plata@intel.com>
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: <stable@vger.kernel.org> # v5.3+
Fixes: f4071997f1de ("drm/i915/ehl: Update MOCS table for EHL")
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191112224757.25116-1-matthew.d.roper@intel.com
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
(cherry picked from commit 046091758b50a5fff79726a31c1391614a3d84c8)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/gt/intel_mocs.c

index 728704bbbe183d44e0c5ffe61086a01e6c0b6580..55fbbaf4e1bc37ca94e3e00776613af0a8ce2e2b 100644 (file)
@@ -199,14 +199,6 @@ static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
        MOCS_ENTRY(15, \
                   LE_3_WB | LE_TC_1_LLC | LE_LRUM(2) | LE_AOM(1), \
                   L3_3_WB), \
-       /* Bypass LLC - Uncached (EHL+) */ \
-       MOCS_ENTRY(16, \
-                  LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
-                  L3_1_UC), \
-       /* Bypass LLC - L3 (Read-Only) (EHL+) */ \
-       MOCS_ENTRY(17, \
-                  LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \
-                  L3_3_WB), \
        /* Self-Snoop - L3 + LLC */ \
        MOCS_ENTRY(18, \
                   LE_3_WB | LE_TC_1_LLC | LE_LRUM(3) | LE_SSE(3), \