hwmon: (ds620) Fix overflows seen when writing temperature limits

BugLink: http://bugs.launchpad.net/bugs/1655969
commit e36ce99ee0815d7919a7b589bfb66f3de50b6bc7 upstream.

Module test reports:

temp1_max: Suspected overflow: [160000 vs. 0]
temp1_min: Suspected overflow: [160000 vs. 0]

This is seen because the values passed when writing temperature limits
are unbound.

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Fixes: 6099469805c2 ("hwmon: Support for Dallas Semiconductor DS620")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

diff --git a/drivers/hwmon/ds620.c b/drivers/hwmon/ds620.c
index edf550fc4eef5c1b2cbbcd94365e7259e1a2049c..0043a4c02b85b4007d1972e50709801510df1a1d 100644 (file)
--- a/drivers/hwmon/ds620.c
+++ b/drivers/hwmon/ds620.c
@@ -166,7 +166,7 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da,
        if (res)
                return res;
 
-       val = (val * 10 / 625) * 8;
+       val = (clamp_val(val, -128000, 128000) * 10 / 625) * 8;
 
        mutex_lock(&data->update_lock);
        data->temp[attr->index] = val;