]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
r8152: replace return with break for ram code speedup mode timeout
authorHayes Wang <hayeswang@realtek.com>
Thu, 22 Apr 2021 08:48:02 +0000 (16:48 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Apr 2021 21:14:45 +0000 (14:14 -0700)
When the timeout occurs, we still have to run the following process
for releasing patch request. Otherwise, the PHY would keep no link.
Therefore, use break to stop the loop of loading firmware and
release the patch request rather than return the function directly.

Fixes: 4a51b0e8a014 ("r8152: support PHY firmware for RTL8156 series")
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index 9119a860e9bd30e60c1acac756628bb61eab6ac8..5b4ed69df64fcfc6e40579d278c48af513fe3c3a 100644 (file)
@@ -4803,7 +4803,7 @@ static void rtl_ram_code_speed_up(struct r8152 *tp, struct fw_phy_speed_up *phy,
 
                if (i == 1000) {
                        dev_err(&tp->intf->dev, "ram code speedup mode timeout\n");
-                       return;
+                       break;
                }
        }