From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 6 Feb 2013 20:27:20 +0000 (+0100)
Subject: qmp: Drop wasteful zero-initialization in qmp_memchar_read()
X-Git-Tag: v1.4.0-rc1~13
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;ds=sidebyside;h=44f3bcd2c7991cc9d096e51e38864135543ea1ce;p=qemu.git

qmp: Drop wasteful zero-initialization in qmp_memchar_read()

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/qemu-char.c b/qemu-char.c
index 9d1c02cd1..b0e4b41bc 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2819,7 +2819,7 @@ char *qmp_memchar_read(const char *device, int64_t size,
 
     count = qemu_chr_cirmem_count(chr);
     size = size > count ? count : size;
-    read_data = g_malloc0(size + 1);
+    read_data = g_malloc(size + 1);
 
     cirmem_chr_read(chr, read_data, size);
 
@@ -2827,6 +2827,7 @@ char *qmp_memchar_read(const char *device, int64_t size,
         data = g_base64_encode(read_data, size);
         g_free(read_data);
     } else {
+        read_data[size] = 0;
         data = (char *)read_data;
     }