From: mdkinney <mdkinney@6f19259b-4bc3-4df7-8a09-765794883524>
Date: Fri, 7 May 2010 22:44:54 +0000 (+0000)
Subject: Fix bug in PciHostBridgeEnumerator().
X-Git-Tag: edk2-stable201903~15880
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;ds=sidebyside;h=8063b47b1ca5aae1788a30568c2996ca81748010;p=mirror_edk2.git

Fix bug in PciHostBridgeEnumerator().

A linked list is created for the list of PCI Root Bridges in the platform.  This list is then traversed to enumerate each PCI Root Bridge.  After enumeration, the RootBridgeDev is destroyed, but it was not removed from the linked list before it was destroyed.  This left the linked list of PCI Root Bridges in a bad state, specially if memory is cleared on frees, or the freed buffer was reallocated.

The fix is to remove the node from the linked list before the RootBridgeDev is destroyed.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10463 6f19259b-4bc3-4df7-8a09-765794883524
---

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
index 548b8a2298..8397a40582 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
@@ -1241,7 +1241,7 @@ PciHostBridgeEnumerator (
       );
 
       FreePool (Configuration);
-      Link = GetNextNode (&RootBridgeList, Link);
+      Link = RemoveEntryList (Link);
       DestroyRootBridge (RootBridgeDev);
     }