From: Jan Kara Date: Tue, 22 Jan 2019 11:35:36 +0000 (+0100) Subject: ext2: Set superblock revision when enabling xattr feature X-Git-Tag: Ubuntu-5.2.0-15.16~2450^2~9 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=032cdc39793fc814d78d7302c3e81048a76f3da5;p=mirror_ubuntu-eoan-kernel.git ext2: Set superblock revision when enabling xattr feature When setting the first xattr, we automatically enable EXT2_FEATURE_COMPAT_EXT_ATTR. However we forget to call ext2_update_dynamic_rev() so in theory if the filesystem was created as ancient one without features support, this could be missed. The consequences are minor anyway - since the feature is compat one, only old e2fsck which does not understand xattrs could do something bad. Reported-by: Andreas Dilger Signed-off-by: Jan Kara --- diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index 4f30876ee325..1e33e0ac8cf1 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -342,6 +342,7 @@ static void ext2_xattr_update_super_block(struct super_block *sb) return; spin_lock(&EXT2_SB(sb)->s_lock); + ext2_update_dynamic_rev(sb); EXT2_SET_COMPAT_FEATURE(sb, EXT2_FEATURE_COMPAT_EXT_ATTR); spin_unlock(&EXT2_SB(sb)->s_lock); mark_buffer_dirty(EXT2_SB(sb)->s_sbh);