From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Sat, 21 Jan 2023 13:30:54 +0000 (+0100)
Subject: ui: factor out not found rendering to common helper
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=04389e49d64de6a7a87475a4711299e3aae5bc34;hp=8686ba103fb206ba21398675660801bde2f99837;p=pve-manager.git

ui: factor out not found rendering to common helper

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 3dd287e3..d8c0bf5a 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -393,6 +393,8 @@ Ext.define('PVE.Utils', {
 	'efidisk but no OMVF BIOS': gettext('EFI Disk without OMVF BIOS'),
     },
 
+    renderNotFound: what => Ext.String.format(gettext("No {0} found"), what),
+
     get_kvm_osinfo: function(value) {
 	var info = { base: 'Other' }; // default
 	if (value) {
diff --git a/www/manager6/node/LVM.js b/www/manager6/node/LVM.js
index 79cce433..28603b30 100644
--- a/www/manager6/node/LVM.js
+++ b/www/manager6/node/LVM.js
@@ -86,7 +86,7 @@ Ext.define('PVE.node.LVMList', {
 	},
     },
 
-    emptyText: gettext('No Volume Groups found'),
+    emptyText: PVE.Utils.renderNotFound('VGs'),
 
     stateful: true,
     stateId: 'grid-node-lvm',
diff --git a/www/manager6/node/LVMThin.js b/www/manager6/node/LVMThin.js
index b9ad4b8d..209a69bd 100644
--- a/www/manager6/node/LVMThin.js
+++ b/www/manager6/node/LVMThin.js
@@ -91,7 +91,7 @@ Ext.define('PVE.node.LVMThinList', {
 	},
     },
 
-    emptyText: gettext('No thinpools found'),
+    emptyText: PVE.Utils.renderNotFound('Thin-Pool'),
 
     stateful: true,
     stateId: 'grid-node-lvmthin',
diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js
index 314882b4..5dbfae90 100644
--- a/www/manager6/storage/IScsiEdit.js
+++ b/www/manager6/storage/IScsiEdit.js
@@ -16,7 +16,7 @@ Ext.define('PVE.storage.IScsiScan', {
 		flex: 1,
 	    },
 	],
-	emptyText: gettext('No iSCSI target found'),
+	emptyText: PVE.Utils.renderNotFound(gettext('iSCSI Target')),
     },
 
     config: {
diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index 1b6edd08..75c7bdb8 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -13,7 +13,7 @@ Ext.define('PVE.storage.VgSelector', {
 		flex: 1,
 	    },
 	],
-	emptyText: gettext('No volume groups found'),
+	emptyText: PVE.Utils.renderNotFound('VGs'),
     },
 
     config: {
@@ -130,7 +130,7 @@ Ext.define('PVE.storage.LunSelector', {
 			},
 		    ],
 		},
-		emptyText: me.listConfig?.emptyText ?? gettext('Nothing found'),
+		emptyText: me.listConfig?.emptyText ?? PVE.Utils.renderNotFound(gettext('Volume')),
 	    });
 	}
 
diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js
index ece5512b..bed5facb 100644
--- a/www/manager6/storage/LvmThinEdit.js
+++ b/www/manager6/storage/LvmThinEdit.js
@@ -9,7 +9,7 @@ Ext.define('PVE.storage.TPoolSelector', {
     allowBlank: false,
 
     listConfig: {
-	emptyText: gettext("No thinpool found"),
+	emptyText: PVE.Utils.renderNotFound('Thin-Pool'),
 	columns: [
 	    {
 		dataIndex: 'lv',
diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www/manager6/storage/ZFSPoolEdit.js
index 1cbdc1ca..b66d131a 100644
--- a/www/manager6/storage/ZFSPoolEdit.js
+++ b/www/manager6/storage/ZFSPoolEdit.js
@@ -14,7 +14,7 @@ Ext.define('PVE.storage.ZFSPoolSelector', {
 		flex: 1,
 	    },
 	],
-	emptyText: gettext('No ZFS Pools found'),
+	emptyText: PVE.Utils.renderNotFound(gettext('ZFS Pool')),
     },
 
     config: {