From: Srinivas Pandruvada Date: Thu, 5 Mar 2020 22:45:32 +0000 (-0800) Subject: tools/power/x86/intel-speed-select: Show error for invalid CPUs in the options X-Git-Tag: Ubuntu-5.10.0-12.13~3213^2~19 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=070fdea13d4ba3ba6ae5a239fe334947921a1b9f;p=mirror_ubuntu-hirsute-kernel.git tools/power/x86/intel-speed-select: Show error for invalid CPUs in the options When --cpu or -c is used to specify target CPUs and non of them are valid, display error. Signed-off-by: Srinivas Pandruvada Signed-off-by: Andy Shevchenko --- diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c index 7a8a315ac8d1..386791aaeca1 100644 --- a/tools/power/x86/intel-speed-select/isst-config.c +++ b/tools/power/x86/intel-speed-select/isst-config.c @@ -425,7 +425,7 @@ static void for_each_online_target_cpu_in_set( void (*callback)(int, void *, void *, void *, void *), void *arg1, void *arg2, void *arg3, void *arg4) { - int i; + int i, found = 0; for (i = 0; i < topo_max_cpus; ++i) { int online; @@ -439,9 +439,14 @@ static void for_each_online_target_cpu_in_set( online = 1; /* online entry for CPU 0 needs some special configs */ - if (online && callback) + if (online && callback) { callback(i, arg1, arg2, arg3, arg4); + found = 1; + } } + + if (!found) + fprintf(stderr, "No valid CPU in the list\n"); } #define BITMASK_SIZE 32