From: Shenglei Zhang Date: Wed, 7 Aug 2019 02:06:10 +0000 (+0800) Subject: UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style X-Git-Tag: edk2-stable201908~103 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=073f2cede820782e37e31bd6664aa53b79bbade4;p=mirror_edk2.git UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style 1. Update CPUStatus to CpuStatus in comments to align comments with code. 2. Add "OUT" attribute for "ProcedureArguments" parameter in function header. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang Reviewed-by: Eric Dong --- diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c index 328d7ae53a..d8d2b6f444 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -1967,7 +1967,7 @@ RegisterSmmEntry ( EFI_MP_SERVICES_PROTOCOL.StartupAllAPs. If caller may pass a value of NULL to deregister any existing startup procedure. - @param[in] ProcedureArguments Allows the caller to pass a list of parameters to the code that is + @param[in,out] ProcedureArguments Allows the caller to pass a list of parameters to the code that is run by the AP. It is an optional common mailbox between APs and the caller to share information @@ -1977,8 +1977,8 @@ RegisterSmmEntry ( **/ EFI_STATUS RegisterStartupProcedure ( - IN EFI_AP_PROCEDURE Procedure, - IN VOID *ProcedureArguments OPTIONAL + IN EFI_AP_PROCEDURE Procedure, + IN OUT VOID *ProcedureArguments OPTIONAL ) { if (Procedure == NULL && ProcedureArguments != NULL) { diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h index ed70055460..8c29f1a558 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -1311,7 +1311,7 @@ RestoreCr2 ( Note that timeout support is optional. Whether an implementation supports this feature can be determined via the Attributes data member. - @param[in,out] CPUStatus This optional pointer may be used to get the status code returned + @param[in,out] CpuStatus This optional pointer may be used to get the status code returned by Procedure when it completes execution on the target AP, or with EFI_TIMEOUT if the Procedure fails to complete within the optional timeout. The implementation will update this variable with @@ -1437,8 +1437,8 @@ InternalSmmStartupAllAPs ( **/ EFI_STATUS RegisterStartupProcedure ( - IN EFI_AP_PROCEDURE Procedure, - IN VOID *ProcedureArguments OPTIONAL + IN EFI_AP_PROCEDURE Procedure, + IN OUT VOID *ProcedureArguments OPTIONAL ); /**