From: Chuck Lever <chuck.lever@oracle.com>
Date: Thu, 4 Dec 2008 19:21:46 +0000 (-0500)
Subject: NSM: Check result of SM_UNMON upcall
X-Git-Tag: Ubuntu-5.2.0-15.16~31337^2~44
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=0c7aef4569f8680951b7dee01dddffb9d2f809ff;p=mirror_ubuntu-eoan-kernel.git

NSM: Check result of SM_UNMON upcall

Make sure any error returned by rpc.statd during an SM_UNMON call is
reported rather than ignored completely.  There isn't much to do with
such an error, but we should log it in any case.

Similar to a recent change to nsm_monitor().

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---

diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
index d61cdc61cb50..3bb71e1b1e1f 100644
--- a/fs/lockd/mon.c
+++ b/fs/lockd/mon.c
@@ -126,6 +126,8 @@ void nsm_unmonitor(const struct nlm_host *host)
 		dprintk("lockd: nsm_unmonitor(%s)\n", nsm->sm_name);
 
 		status = nsm_mon_unmon(nsm, SM_UNMON, &res);
+		if (res.status != 0)
+			status = -EIO;
 		if (status < 0)
 			printk(KERN_NOTICE "lockd: cannot unmonitor %s\n",
 					nsm->sm_name);