From: Johan Hovold <johan@kernel.org>
Date: Mon, 26 Jan 2015 11:02:45 +0000 (+0100)
Subject: gpio: sysfs: fix memory leak in gpiod_export_link
X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~12971^2~1
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=0f303db08df0df9bd0966443ad6001e63960af16;p=mirror_ubuntu-focal-kernel.git

gpio: sysfs: fix memory leak in gpiod_export_link

Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when creating a link.

Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
using sysfs links")
Cc: stable <stable@vger.kernel.org>	# v2.6.32
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index f62aa115d79a..4667830f350e 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -648,6 +648,7 @@ int gpiod_export_link(struct device *dev, const char *name,
 		if (tdev != NULL) {
 			status = sysfs_create_link(&dev->kobj, &tdev->kobj,
 						name);
+			put_device(tdev);
 		} else {
 			status = -ENODEV;
 		}