From: Christoph Hellwig Date: Sat, 3 Jun 2017 07:37:55 +0000 (+0200) Subject: scsi/osd: don't save block errors into req_results X-Git-Tag: v4.13~328^2~86 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=10f64ec5dded10f680f891e92fb4c65f4b7147a2;p=mirror_ubuntu-bionic-kernel.git scsi/osd: don't save block errors into req_results We will only have sense data if the command executed and got a SCSI result, so this is pointless. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Signed-off-by: Jens Axboe --- diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index 8a1b94816419..14785177ce7b 100644 --- a/drivers/scsi/osd/osd_initiator.c +++ b/drivers/scsi/osd/osd_initiator.c @@ -477,7 +477,7 @@ static void _set_error_resid(struct osd_request *or, struct request *req, int error) { or->async_error = error; - or->req_errors = scsi_req(req)->result ? : error; + or->req_errors = scsi_req(req)->result; or->sense_len = scsi_req(req)->sense_len; if (or->sense_len) memcpy(or->sense, scsi_req(req)->sense, or->sense_len);