From: Dinghao Liu <dinghao.liu@zju.edu.cn>
Date: Thu, 21 May 2020 11:07:47 +0000 (+0200)
Subject: media: s5k6a3: Fix runtime PM imbalance on error
X-Git-Tag: Ubuntu-5.10.0-12.13~2169^2~311
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=157282a5c6273976b31cf4ba4b1c46663f6519d1;p=mirror_ubuntu-hirsute-kernel.git

media: s5k6a3: Fix runtime PM imbalance on error

pm_runtime_get() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c
index bc6cc5a558db..f26c168ef942 100644
--- a/drivers/media/i2c/s5k6a3.c
+++ b/drivers/media/i2c/s5k6a3.c
@@ -197,7 +197,7 @@ static int __s5k6a3_power_on(struct s5k6a3 *sensor)
 
 	ret = pm_runtime_get(sensor->dev);
 	if (ret < 0)
-		return ret;
+		goto error_rpm_put;
 
 	ret = regulator_enable(sensor->supplies[i].consumer);
 	if (ret < 0)