From: zhong jiang Date: Thu, 20 Sep 2018 09:37:42 +0000 (+0800) Subject: net: cxgb3: remove redundant null pointer check before kfree_skb X-Git-Tag: Ubuntu-5.0.0-8.9~1262^2~302^2~4 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=16a3f50f05985cbea468e043cd18394158eff820;p=mirror_ubuntu-disco-kernel.git net: cxgb3: remove redundant null pointer check before kfree_skb kfree_skb has taken the null pointer into account. hence it is safe to remove the redundant null pointer check before kfree_skb. Signed-off-by: zhong jiang Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c index 50cd660732c5..84604aff53ce 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c @@ -1302,8 +1302,7 @@ void cxgb3_offload_deactivate(struct adapter *adapter) rcu_read_unlock(); RCU_INIT_POINTER(tdev->l2opt, NULL); call_rcu(&d->rcu_head, clean_l2_data); - if (t->nofail_skb) - kfree_skb(t->nofail_skb); + kfree_skb(t->nofail_skb); kfree(t); }