From: Ben Pfaff <blp@ovn.org>
Date: Sat, 18 Aug 2018 17:17:37 +0000 (-0700)
Subject: netdev-linux: Avoid division by 0 if kernel reports bad scheduler data.
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=1bab4901c45c9c7b0121836ccb2aa2b004a0cfd6;p=ovs.git

netdev-linux: Avoid division by 0 if kernel reports bad scheduler data.

If the kernel reported a value of 0 for the second value in
/proc/net/psched, it would cause a division-by-zero fault in
read_psched().  I don't know of a kernel that would actually do that, but
it's still better to be safe.

Found by clang static analyzer.

Reported-by: Bhargava Shastry <bshastry@sect.tu-berlin.de>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
---

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 0c42268d9..e16ea58a0 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -5166,7 +5166,7 @@ read_psched(void)
     VLOG_DBG("%s: psched parameters are: %u %u %u %u", fn, a, b, c, d);
     fclose(stream);
 
-    if (!a || !c) {
+    if (!a || !b || !c) {
         VLOG_WARN("%s: invalid scheduler parameters", fn);
         goto exit;
     }