From: Julia Lawall <julia.lawall@lip6.fr>
Date: Mon, 25 Jan 2016 15:21:54 +0000 (+0100)
Subject: usb: gadget: rndis: fix itnull.cocci warnings
X-Git-Tag: Ubuntu-5.13.0-19.19~16196^2~113
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=1c17a353c5a8346b1ce128c60ffb862d156f7e7e;p=mirror_ubuntu-jammy-kernel.git

usb: gadget: rndis: fix itnull.cocci warnings

The index variable of list_for_each_entry_safe is an offset from a list
pointer, and thus should not be NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Geliang Tang <geliangtang@163.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
index 34a76db2c8fd..943c21aafd3b 100644
--- a/drivers/usb/gadget/function/rndis.c
+++ b/drivers/usb/gadget/function/rndis.c
@@ -1009,7 +1009,7 @@ void rndis_free_response(struct rndis_params *params, u8 *buf)
 	rndis_resp_t *r, *n;
 
 	list_for_each_entry_safe(r, n, &params->resp_queue, list) {
-		if (r && r->buf == buf) {
+		if (r->buf == buf) {
 			list_del(&r->list);
 			kfree(r);
 		}