From: Yifeng Sun Date: Thu, 1 Nov 2018 22:05:31 +0000 (-0700) Subject: ofp-actions: Let parse_UNROLL_XLATE return error message instead of aborting program X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=1d478a8008405dc1e47e6bb1d0389e91927cb016;p=ovs.git ofp-actions: Let parse_UNROLL_XLATE return error message instead of aborting program Currently, if unroll_xlate is passed to ovs-ofctl as one of actions, let say 'ovs-ofctl add-flow br0 in_port=1,actions=unroll_xlate', ovs-ofctl will crash. This patch fixes it by returning an error message. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11184 Signed-off-by: Yifeng Sun Signed-off-by: Ben Pfaff --- diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index a80a4a308..f25fdec64 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -5842,7 +5842,8 @@ static char * OVS_WARN_UNUSED_RESULT parse_UNROLL_XLATE(char *arg OVS_UNUSED, const struct ofpact_parse_params *pp OVS_UNUSED) { - OVS_NOT_REACHED(); + return xasprintf("UNROLL is an internal action " + "that shouldn't be used via OpenFlow"); } static void