From: Dan Carpenter Date: Fri, 20 Jul 2012 11:17:00 +0000 (+0300) Subject: drm/radeon: check for allocation failure in radeon_ring_backup() X-Git-Tag: Ubuntu-5.0.0-8.9~15565^2~6 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=1e179d4e283bd197035960ef751b5ccac06cbf91;p=mirror_ubuntu-disco-kernel.git drm/radeon: check for allocation failure in radeon_ring_backup() Static checkers complain if this we don't check for allocation failure. Also we can use the new kmalloc_array() function here as a cleanup. Signed-off-by: Dan Carpenter Reviewed-by: Christian König Signed-off-by: Dave Airlie --- diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c index f2fc25de0b2f..ec79b3750430 100644 --- a/drivers/gpu/drm/radeon/radeon_ring.c +++ b/drivers/gpu/drm/radeon/radeon_ring.c @@ -594,7 +594,11 @@ unsigned radeon_ring_backup(struct radeon_device *rdev, struct radeon_ring *ring } /* and then save the content of the ring */ - *data = kmalloc(size * 4, GFP_KERNEL); + *data = kmalloc_array(size, sizeof(uint32_t), GFP_KERNEL); + if (!*data) { + mutex_unlock(&rdev->ring_lock); + return 0; + } for (i = 0; i < size; ++i) { (*data)[i] = ring->ring[ptr++]; ptr &= ring->ptr_mask;