From: David Howells <dhowells@redhat.com>
Date: Fri, 12 Jun 2020 22:58:51 +0000 (+0100)
Subject: afs: afs_write_end() should change i_size under the right lock
X-Git-Tag: v5.15~3551^2~10
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=1f32ef79897052ef7d3d154610d8d6af95abde83;p=mirror_ubuntu-kernels.git

afs: afs_write_end() should change i_size under the right lock

Fix afs_write_end() to change i_size under vnode->cb_lock rather than
->wb_lock so that it doesn't race with afs_vnode_commit_status() and
afs_getattr().

The ->wb_lock is only meant to guard access to ->wb_keys which isn't
accessed by that piece of code.

Fixes: 4343d00872e1 ("afs: Get rid of the afs_writeback record")
Signed-off-by: David Howells <dhowells@redhat.com>
---

diff --git a/fs/afs/write.c b/fs/afs/write.c
index 9270bb01be67..a55cb73e0449 100644
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -194,11 +194,11 @@ int afs_write_end(struct file *file, struct address_space *mapping,
 
 	i_size = i_size_read(&vnode->vfs_inode);
 	if (maybe_i_size > i_size) {
-		spin_lock(&vnode->wb_lock);
+		write_seqlock(&vnode->cb_lock);
 		i_size = i_size_read(&vnode->vfs_inode);
 		if (maybe_i_size > i_size)
 			i_size_write(&vnode->vfs_inode, maybe_i_size);
-		spin_unlock(&vnode->wb_lock);
+		write_sequnlock(&vnode->cb_lock);
 	}
 
 	if (!PageUptodate(page)) {