From: Dan Carpenter Date: Wed, 26 Jun 2019 10:10:41 +0000 (+0300) Subject: HID: intel-ish-hid: Fix a use after free in load_fw_from_host() X-Git-Tag: Ubuntu-5.13.0-19.19~8290^2~5 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=21acee4ecf9c3d9eff545f50e79c321a0c35d9b3;p=mirror_ubuntu-jammy-kernel.git HID: intel-ish-hid: Fix a use after free in load_fw_from_host() We have to print the filename first before we can kfree it. Fixes: 91b228107da3 ("HID: intel-ish-hid: ISH firmware loader client driver") Signed-off-by: Dan Carpenter Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c index 22ba21457035..aa2dbed30fc3 100644 --- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c +++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c @@ -816,9 +816,9 @@ static int load_fw_from_host(struct ishtp_cl_data *client_data) goto end_err_fw_release; release_firmware(fw); - kfree(filename); dev_info(cl_data_to_dev(client_data), "ISH firmware %s loaded\n", filename); + kfree(filename); return 0; end_err_fw_release: