From: Milton Miller <miltonm@bga.com>
Date: Fri, 10 Oct 2008 01:56:45 +0000 (+0000)
Subject: powerpc/smp: No need to set_need_resched when getting a resched IPI
X-Git-Tag: Ubuntu-5.10.0-12.13~36378^2~12
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=22d660ffd0db8d136b122751287d186e869ca474;p=mirror_ubuntu-hirsute-kernel.git

powerpc/smp: No need to set_need_resched when getting a resched IPI

The comment in the code was asking "Do we have to do this?", and according
to x86 and s390 the answer is no, the scheduler will do it before calling
the arch hook.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 5337ca7bb649..3ee736fa8b1d 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -101,8 +101,7 @@ void smp_message_recv(int msg)
 		generic_smp_call_function_interrupt();
 		break;
 	case PPC_MSG_RESCHEDULE:
-		/* XXX Do we have to do this? */
-		set_need_resched();
+		/* we notice need_resched on exit */
 		break;
 	case PPC_MSG_CALL_FUNC_SINGLE:
 		generic_smp_call_function_single_interrupt();