From: Mike Snitzer Date: Tue, 3 Jul 2012 11:55:33 +0000 (+0100) Subject: dm persistent data: fix shadow_info_leak on dm_tm_destroy X-Git-Tag: Ubuntu-5.2.0-15.16~17714^2~3 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=25d7cd6faa7ae6ed2565617c3ee2500ccb8a9f7f;p=mirror_ubuntu-eoan-kernel.git dm persistent data: fix shadow_info_leak on dm_tm_destroy Cleanup the shadow table before destroying the transaction manager. Reference: leak was identified with kmemleak when running test_discard_random_sectors in the thinp-test-suite. Signed-off-by: Mike Snitzer Cc: stable@vger.kernel.org Signed-off-by: Alasdair G Kergon --- diff --git a/drivers/md/persistent-data/dm-transaction-manager.c b/drivers/md/persistent-data/dm-transaction-manager.c index 400fe144c0cd..02bf78e9d10d 100644 --- a/drivers/md/persistent-data/dm-transaction-manager.c +++ b/drivers/md/persistent-data/dm-transaction-manager.c @@ -138,6 +138,9 @@ EXPORT_SYMBOL_GPL(dm_tm_create_non_blocking_clone); void dm_tm_destroy(struct dm_transaction_manager *tm) { + if (!tm->is_clone) + wipe_shadow_table(tm); + kfree(tm); } EXPORT_SYMBOL_GPL(dm_tm_destroy);