From: Takashi Iwai <tiwai@suse.de>
Date: Fri, 13 Mar 2020 13:02:23 +0000 (+0100)
Subject: ALSA: pcm: Fix superfluous snprintf() usage
X-Git-Tag: Ubuntu-5.13.0-19.19~6345^2~6^2~10
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=296a37fd029dd8a911396e3c28e0bbd5a2720a5d;p=mirror_ubuntu-jammy-kernel.git

ALSA: pcm: Fix superfluous snprintf() usage

show_pcm_class() returns obviously a short string that can't overflow
PAGE_SIZE.  And even if it were to overflow, using snprintf() there is
just wrong, as it doesn't return the correct size.
So simplify with sprintf() instead.

Link: https://lore.kernel.org/r/20200313130223.8908-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index a141a301369f..b6d2331a82f7 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -1019,7 +1019,7 @@ static ssize_t show_pcm_class(struct device *dev,
 		str = "none";
 	else
 		str = strs[pcm->dev_class];
-        return snprintf(buf, PAGE_SIZE, "%s\n", str);
+	return sprintf(buf, "%s\n", str);
 }
 
 static DEVICE_ATTR(pcm_class, 0444, show_pcm_class, NULL);