From: Michael Büsch Date: Tue, 31 Jul 2018 19:14:04 +0000 (+0200) Subject: b43/leds: Ensure NUL-termination of LED name string X-Git-Tag: Ubuntu-5.2.0-15.16~3800^2~25^2~3 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=2aa650d1950fce94f696ebd7db30b8830c2c946f;p=mirror_ubuntu-eoan-kernel.git b43/leds: Ensure NUL-termination of LED name string strncpy might not NUL-terminate the string, if the name equals the buffer size. Use strlcpy instead. Signed-off-by: Michael Buesch Cc: stable@vger.kernel.org Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/broadcom/b43/leds.c b/drivers/net/wireless/broadcom/b43/leds.c index cb987c2ecc6b..87131f663292 100644 --- a/drivers/net/wireless/broadcom/b43/leds.c +++ b/drivers/net/wireless/broadcom/b43/leds.c @@ -131,7 +131,7 @@ static int b43_register_led(struct b43_wldev *dev, struct b43_led *led, led->wl = dev->wl; led->index = led_index; led->activelow = activelow; - strncpy(led->name, name, sizeof(led->name)); + strlcpy(led->name, name, sizeof(led->name)); atomic_set(&led->state, 0); led->led_dev.name = led->name;