From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 6 Nov 2020 19:24:15 +0000 (+0300)
Subject: auxdisplay: fix use after free in lcd2s_i2c_remove()
X-Git-Tag: Ubuntu-5.11.0-11.12~929^2~3
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=2cfd72f81cf69c2659c6d2121308b55416229beb;p=mirror_ubuntu-hirsute-kernel.git

auxdisplay: fix use after free in lcd2s_i2c_remove()

The kfree() needs to be moved down a line to prevent a use after free.

Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---

diff --git a/drivers/auxdisplay/lcd2s.c b/drivers/auxdisplay/lcd2s.c
index cfa5f86deeef..3eb7f04db6cb 100644
--- a/drivers/auxdisplay/lcd2s.c
+++ b/drivers/auxdisplay/lcd2s.c
@@ -348,8 +348,8 @@ static int lcd2s_i2c_remove(struct i2c_client *i2c)
 {
 	struct lcd2s_data *lcd2s = i2c_get_clientdata(i2c);
 
-	kfree(lcd2s->charlcd);
 	charlcd_unregister(lcd2s->charlcd);
+	kfree(lcd2s->charlcd);
 	return 0;
 }