From: Luis Chamberlain Date: Mon, 27 Sep 2021 22:02:49 +0000 (-0700) Subject: block/swim3: add error handling support for add_disk() X-Git-Tag: v5.19~2012^2~70 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=2d4bcf76429713c2ca0093c11b5b75072db95a50;p=mirror_ubuntu-kernels.git block/swim3: add error handling support for add_disk() We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain Link: https://lore.kernel.org/r/20210927220302.1073499-2-mcgrof@kernel.org Signed-off-by: Jens Axboe --- diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c index 965af0a3e95b..f7e3482e846b 100644 --- a/drivers/block/swim3.c +++ b/drivers/block/swim3.c @@ -1229,7 +1229,9 @@ static int swim3_attach(struct macio_dev *mdev, disk->flags |= GENHD_FL_REMOVABLE; sprintf(disk->disk_name, "fd%d", floppy_count); set_capacity(disk, 2880); - add_disk(disk); + rc = add_disk(disk); + if (rc) + goto out_cleanup_disk; disks[floppy_count++] = disk; return 0;