From: David S. Miller Date: Wed, 26 Sep 2018 17:04:23 +0000 (-0700) Subject: Merge branch 'net-bridge-convert-bool-options-to-bits' X-Git-Tag: Ubuntu-5.0.0-8.9~1262^2~254 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=30b0594a3e6c2bcbe5bd59753d0319d6f9925e40;p=mirror_ubuntu-disco-kernel.git Merge branch 'net-bridge-convert-bool-options-to-bits' Nikolay Aleksandrov says: ==================== net: bridge: convert bool options to bits A lot of boolean bridge options have been added around the net_bridge structure resulting in holes and more importantly different cache lines that need to be fetched in the fast path. This set moves all of those to bits in a bitfield which resides in a hot cache line thus reducing the size of net_bridge, the number of holes and the number of cache lines needed for the fast path. The set is also sent in preparation for new boolean options to avoid spreading them in the structure and making new holes. One nice side-effect is that we avoid potential race conditions by using the bitops since some of the options were bits being directly set in parallel risking hard to debug issues (has_ipv6_addr). Before: size: 1184, holes: 8, sum holes: 30 After: size: 1160, holes: 3, sum holes: 7 Patch 01 is a trivial style fix Patch 02 adds the new options bitfield and converts the vlan boolean options to bits Patches 03-08 convert the rest of the boolean options to bits Patch 09 re-arranges a few fields in net_bridge to further reduce size v2: patch 09: remove the comment about offload_fwd_mark in net_bridge and leave it where it is now, thanks to Ido for spotting it ==================== Signed-off-by: David S. Miller --- 30b0594a3e6c2bcbe5bd59753d0319d6f9925e40