From: Shivasharan S Date: Wed, 17 Oct 2018 06:37:50 +0000 (-0700) Subject: scsi: megaraid_sas: Remove spin lock for dpc operation X-Git-Tag: v5.15~7315^2~237 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=34bd9f27e39be6e4bfb69bc8e79a7f5c4aa1c8c4;p=mirror_ubuntu-kernels.git scsi: megaraid_sas: Remove spin lock for dpc operation Optimization: No need to hold hba_lock in dpc context for reading atomic variable. Signed-off-by: Shivasharan S Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 7df7e2c8d4b3..259fc892703e 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -3573,18 +3573,13 @@ megasas_complete_cmd_dpc_fusion(unsigned long instance_addr) { struct megasas_instance *instance = (struct megasas_instance *)instance_addr; - unsigned long flags; u32 count, MSIxIndex; count = instance->msix_vectors > 0 ? instance->msix_vectors : 1; /* If we have already declared adapter dead, donot complete cmds */ - spin_lock_irqsave(&instance->hba_lock, flags); - if (atomic_read(&instance->adprecovery) == MEGASAS_HW_CRITICAL_ERROR) { - spin_unlock_irqrestore(&instance->hba_lock, flags); + if (atomic_read(&instance->adprecovery) == MEGASAS_HW_CRITICAL_ERROR) return; - } - spin_unlock_irqrestore(&instance->hba_lock, flags); for (MSIxIndex = 0 ; MSIxIndex < count; MSIxIndex++) complete_cmd_fusion(instance, MSIxIndex);