From: Trond Myklebust Date: Wed, 19 Aug 2015 05:14:20 +0000 (-0500) Subject: Revert "NFSv4: Remove incorrect check in can_open_delegated()" X-Git-Tag: Ubuntu-5.10.0-12.13~14142^2~53 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=36319608e28701c07cad80ae3be8b0fdfb1ab40f;p=mirror_ubuntu-hirsute-kernel.git Revert "NFSv4: Remove incorrect check in can_open_delegated()" This reverts commit 4e379d36c050b0117b5d10048be63a44f5036115. This commit opens up a race between the recovery code and the open code. Reported-by: Olga Kornievskaia Cc: stable@vger.kernel # v4.0+ Signed-off-by: Trond Myklebust --- diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 9e9f7816cf24..95c5e8d39bef 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -1156,6 +1156,8 @@ static int can_open_delegated(struct nfs_delegation *delegation, fmode_t fmode) return 0; if ((delegation->type & fmode) != fmode) return 0; + if (test_bit(NFS_DELEGATION_NEED_RECLAIM, &delegation->flags)) + return 0; if (test_bit(NFS_DELEGATION_RETURNING, &delegation->flags)) return 0; nfs_mark_delegation_referenced(delegation);